Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored link checks #2204

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Refactored link checks #2204

merged 3 commits into from
Dec 19, 2024

Conversation

Root-Core
Copy link
Contributor

This fixes some issues with the link checker.
The commit 2bc95a1 is reverted, but I can't find a reason why it should be a problem. Feedback is appreciated.

  • Check w_download_to
  • Check only URL, not whole line
  • Find lines that don't start with w_download
  • Allow escaped $ in URL
  • Escape '$' to '%24'

CC #2199

- Check w_download_to
- Check only URL, not whole line
- Find lines that don't start with w_download
- Allow escaped $ in URL
- Escape '\$' to '%24'
src/linkcheck.sh Outdated Show resolved Hide resolved
@Root-Core Root-Core requested a review from austin987 September 19, 2024 20:40
@Root-Core
Copy link
Contributor Author

@austin987 Is there anything else that needs to be changed?

@austin987 austin987 merged commit 6ab0bc7 into Winetricks:master Dec 19, 2024
@Root-Core Root-Core deleted the url_check branch December 19, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants